Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules modernization #412

Merged
merged 52 commits into from
Dec 11, 2020
Merged

Modules modernization #412

merged 52 commits into from
Dec 11, 2020

Conversation

grob
Copy link
Member

@grob grob commented Nov 3, 2020

Quite a code bomb, but no (intentional) functional changes: replaced var declarations in all standard modules with const/let, modernized code where possible. All tests pass, some tests were added.

Note that due to #411 i had to change some module imports to eg. const binary = require("binary"); and use binary.ByteArray throughout the module.

Robert Gaggl added 30 commits October 29, 2020 13:02
binary module uses defineClass to modify the global scope, so we can't (re)declare ie. const Binary
disentangled Frame and Profiler constructors: moved Frame constructor out of
Profiler constructor, and pass the stack it needs as argument
Copy link
Member

@botic botic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good someone started this 👍 I just flew over all sections, nothing in which would prevent a merge.

@botic botic added this to the 3.0.0 milestone Dec 11, 2020
@botic
Copy link
Member

botic commented Dec 11, 2020

@grob ready to merge, or still outstanding work from your side?

@grob
Copy link
Member Author

grob commented Dec 11, 2020

No, i'm fine with that (#415 is pending too).

@botic botic merged commit b085a7a into ringo:master Dec 11, 2020
@grob grob deleted the modules-modernization branch December 12, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants